راهنمای Refactor یا بازسازی کد — به زبان ساده

1function endpoint(service, version = '') {
2  let protocol
3  let domain
4
5  if (service === 'webclient') {
6    protocol = __CLIENT_PROTOCOL__
7    domain = `${__ENV__}-${service}.${__DOMAIN__}`
8    if (__SERVER__) {
9      protocol = 'http'
10    } else if (__ENV__ === 'production') {
11      domain = `www.${__DOMAIN__}`
12    }
13  } else {
14    if (__ENV__ !== 'local') {
15      if (__SERVER__) {
16        protocol = 'http'
17        domain = `${__ENV__}-${service}`
18        domain += `.${__DOMAIN__}`
19      } else {
20        protocol = __CLIENT_PROTOCOL__
21        domain = `${__ENV__}-api.${__DOMAIN__}`
22        if (service !== 'core') {
23          domain += `/${service}`
24        }
25        if (version) {
26          domain += `/${version}`
27        }
28      }
29    } else {
30      protocol = 'http'
31
32      if (service === 'core') {
33        if (__CLIENT__) {
34          domain = `api.${__DOMAIN__}`
35        } else {
36          domain = `api.${__DOMAIN__}:80`
37        }
38      } else {
39        if (__CLIENT__) {
40          domain = `api.${__DOMAIN__}/${service}/${version}`
41        } else {
42          domain = `api.${__DOMAIN__}:80/${service}/${version}`
43        }
44      }
45    }
46  }
47
48  const url = `${protocol}://${domain}`
49
50  return url
51}
52
53export default endpoint

1import endpoint from 'config/endpoint'
2
3describe('endpoint.js', () => {
4  global.__DOMAIN__ = 'gousto.local'
5  let service
6
7  describe('when the service is "webclient"', () => {
8    beforeEach(() => {
9      service = 'webclient'
10    })
11
12    describe('and being in the server side', () => {
13      beforeEach(() => {
14        global.__SERVER__ = true
15        global.__ENV__ = 'whateverenv'
16      })
17
18      test('an http address with the corresponding ENV, SERVICE and DOMAIN is returned', () => {
19        const url = endpoint(service)
20        expect(url).toBe(`http://${__ENV__}-${service}.${__DOMAIN__}`)
21      })
22    })
23
24    describe('and not being in the server side', () => {
25      ...
26      describe('and the environment is production', () => {
27        ...
28        test('an https address with "www" and without the service, but with the DOMAIN is returned', () => {...})
29      })
30
31      describe('and the environment is not production', () => {
32        ...
33        test('an https address with the corresponding ENV, SERVICE and DOMAIN is returned', () => {...})
34      })
35    })
36  })
37
38  describe('when the service is not "webclient"', () => {
39    ...
40    describe('and the env is not "local"', () => {
41      ...
42      describe('and being in the server side', () => {
43        ...
44        test('an http address with the corresponding ENV, SERVICE and DOMAIN is returned', () => {...})
45      })
46
47      describe('and not being in the server side', () => {
48        ...
49        describe('and the service is core', () => {
50          ...
51          test('an https API address with the corresponding ENV and DOMAIN is returned', () => {...})
52
53          describe('and a version was passed', () => {
54            test('an https API address with the corresponding ENV, DOMAIN, SERVICE and VERSION is returned', () => {...})
55          })
56        })
57
58        describe('and a version was passed', () => {
59          test('an https API address with the corresponding ENV, DOMAIN, SERVICE and VERSION is returned', () => {...})
60        })
61
62        describe('and a version was not passed', () => {
63          test('an https API address with the corresponding ENV, DOMAIN and SERVICE is returned', () => {...})
64        })
65      })
66    })
67
68    describe('and the env is "local"', () => {
69      ...
70      describe('and the service is core', () => {
71        ...
72        describe('and being in the client side', () => {
73          ...
74          test('an http API address with the corresponding DOMAIN is returned', () => {...})
75        })
76
77        describe('and not being in the client side', () => {
78          ...
79          test('an http API address with the corresponding DOMAIN and port 80 is returned', () => {...})
80        })
81      })
82
83      describe('and the service is not core', () => {
84        ...
85        describe('and being in the client side', () => {
86          ...
87          test('an http API address with the corresponding DOMAIN, SERVICE and VERSION is returned', () => {...})
88        })
89
90        describe('and not being in the client side', () => {
91          ...
92          test('an http API address with the corresponding DOMAIN, port 80, SERVICE and VERSION is returned', () => {...})
93        })
94      })
95    })
96  })
97})

1const getProtocol = (service, isServerSide, environment) => {
2  if (service === 'webclient') {
3    if (isServerSide) {
4      return 'http'
5    }
6
7    return 'https'
8  } else {
9    if (environment === 'local') {
10      return 'http'
11    } else {
12      if (isServerSide) {
13        return 'http'
14      } else {
15        return 'https'
16      }
17    }
18  }
19}
20
21function endpoint(service, version = '') {
22  const protocol = getProtocol(service, __SERVER__, __ENV__)
23  
24  // Rest of the mess here
25  ...
26  
27  const url = `${protocol}://${domain}`
28
29  return url
30}
31
32export default endpoint

1const getProtocol = (service, isServerSide, environment) => {
2  if (service === 'webclient' && !isServerSide) {
3    return 'https'
4  }
5  
6  if (service !== 'webclient' && !isServerSide && environment !== 'local') {
7   return 'https' 
8  }
9  
10  return 'http'
11}

1const getProtocol = (service, isServerSide, environment) => {
2  if (isServerSide) {
3    return 'http'
4  }
5  
6  if (service === 'webclient') {
7    return 'https'
8  }
9  
10  if (service !== 'webclient' && environment !== 'local') {
11   return 'https' 
12  }
13  
14  return 'http'
15}

1const getProtocol = (service, isServerSide, environment) => {
2  ...
3  if (service === 'webclient' || 
4      (service !== 'webclient' && environment !== 'local')) {
5    return 'https'
6  }
7  ...
8}

1const getProtocol = (service, isServerSide, environment) => {
2  ...
3  if (service === 'webclient' || 
4      (service !== 'webclient' && environment !== 'local')) {
5    return 'https'
6  }
7  ...
8}

1...
2
3function endpoint(service, version = '') {
4  const protocol = getProtocol(service, __SERVER__, __ENV__)
5  const subdomain = getSubdomain(service, __SERVER__, __ENV__)
6  const path = getPath(service, __SERVER__, __ENV__, version)
7  const port = getPort(service, __ENV__, __CLIENT__)
8
9  return `${protocol}://${subdomain}.${__DOMAIN__}${port}${path}`
10}
11
12export default endpoint

1const getProtocol = (service, isServerSide, environment) => {
2  if (isServerSide) {
3    return 'http'
4  }
5
6  if (service === 'webclient' || environment !== 'local') {
7    return 'https'
8  }
9
10  return 'http'
11}
12
13const getPath = (service, isServerSide, environment, version) => {
14  const isCore = service === 'core'
15  let path = ''
16
17  if (service === 'webclient') {
18    return path
19  }
20
21  if (environment === 'local') {
22    if (!isCore) {
23      return `/${service}/${version}`
24    }
25  }
26
27  if (isServerSide) {
28    return path
29  }
30
31  if (!isCore) {
32    path += `/${service}`
33  }
34  if (version) {
35    path += `/${version}`
36  }
37
38  return path
39}
40
41const getPort = (service, environment, isClientSide) => {
42  if (service !== 'webclient' && environment === 'local' && !isClientSide) {
43    return ':80'
44  }
45
46  return ''
47}
48
49const getSubdomain = (service, isServerSide, environment) => {
50  if (service === 'webclient') {
51    if (!isServerSide && environment === 'production') {
52      return 'www'
53    }
54
55    return `${environment}-${service}`
56  }
57
58  if (environment === 'local') {
59    return 'api'
60  }
61
62  if (isServerSide) {
63    return `${environment}-${service}`
64  }
65
66  return `${environment}-api`
67}
68
69function endpoint(service, version = '') {
70  const protocol = getProtocol(service, __SERVER__, __ENV__)
71  const subdomain = getSubdomain(service, __SERVER__, __ENV__)
72  const path = getPath(service, __SERVER__, __ENV__, version)
73  const port = getPort(service, __ENV__, __CLIENT__)
74
75  return `${protocol}://${subdomain}.${__DOMAIN__}${port}${path}`
76}
77
78export default endpoint