Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian/Farsi translation #137

Merged
merged 3 commits into from Jan 25, 2022
Merged

Conversation

mahdavipanah
Copy link
Contributor

@mahdavipanah mahdavipanah commented Dec 24, 2019

Hi,
I am aware that two other pull requests for the translation to the Persian (Farsi) language are active right now, but these are the differences between my pull request and the two other (#118 and #136):

  • I think the tone of my translation is more natural and comfortable
  • Because Github Markdown does not support RTL languages, I tried my best to write the README-fa.md as readable as possible. It is Right-to-Left, and it also solves the problem of checklists when making a markdown document RTL in Github. (fa translation #136 is not RTL which is almost not readable, and Add Farsi/Persian complete translation #118 is RTL but does not solve the problem of text and checkboxes overlapping in RTL documents)

@mahdavipanah mahdavipanah changed the title Add persian Add Persian/Farsi translation Dec 24, 2019
Copy link
Collaborator

@Maikuolan Maikuolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@netcode Any thoughts?

@Maikuolan Maikuolan merged commit 4877d91 into shieldfy:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants